Abdelrazak Younes wrote:
Abdelrazak Younes wrote:
I've tried it and I like it. Some colors needs adjustment though
(Yellow 'Note' text is not very visible without the grey background).
More importantly there's three problems:
1) The cursor blinking is stopped when the mouse is moved. This is
done in WorkArea::dispatch() IIRC. You might want to special case
mouse_motion and button==none so that it is now stopped.
2) The cursor needs to be changed into an arrow when over a button.
3) There's no way to enter a collapsed inset without the mouse. This
is not your doing but now it is more visible. IMO, we need a visual
hint to indicate that there is something to be edited inside this
inset. I think the background should also be toggled when the keyboard
cursor is just before and after the inset.
4) The toggling does not work for opened insets, only for collapsed one.
5) The button redraw provokes a full screen redraw!
IMO, at least 1) and 4) needs to be corrected before this goes in.
Unfortunately 4) might be difficult to correct. At best you can restrain
the redrawing to the current paragraph... but this is so wrong! This is
of course not your doing but one of the drawbacks of LyX painting strategy.
A more correct way to solve these performance problems will be to split
the InsetBase::draw() method in three:
- drawBackground()
- drawDecoration()
- drawText()
But this is too much work for 1.5. This will wait for 1.6.
Abdel.
