Gady Kozma <[EMAIL PROTECTED]> writes:
| This patch against 1.1.4fix1 redoes the layout menu in the toolbar.
|
| A) The menu is alphabetaized.
| B) The menu now displays the depth too. For example, suppose you have an
| enumerate of depth 1, with the enclosing environment a proof. The box in the
| toolbar will show "Enumerate in Proof" (it was slightly widened for this) and
| the menu will be twice as long, allowing you to chose either an "X in proof"
| for all layouts X (which just sets the layout) or an "X" which sets both the
| layout and the depth.
|
| I am embedding lots of stuff in Proof and this change really helps to see
| what's going on.
It very nice to see someone take interest in this code. However this
patch is not going in as is, if not for anything else that this needs
some discussion.
I have also a couple of general comments on the code:
- it is very C'ish
- you use c-string functions a lot instead of std::string
- reserved variable names (those beginnign with _)
- _never_ use qsort in a C++ program use std::sort.
Also you really should write your code against the cvs version, then
it is so much easier to apply (and sometimes to comment on)
Also please join the lyx-devel mailing list so that you can take part
in the discussion, you obvioulsy have some comments to contribute.
Lgb
