Am Montag, 30. Oktober 2006 20:03 schrieb Enrico Forestieri:
> An hack? What do you mean?
This one:
if (s[0] < 0x80 && isAlpha(static_cast<char>(s[0])))
We should have an isAlpha that takes a lyx::char_type and use
if (isAlpha(s[0]))
instead, even if that isAlpha looks like this:
bool isAlpha(lyx::char_type c)
{
return c < 0x80 && isAlpha(static_cast<char>(c));
}
The places where a lyx::char_type is treated as a char should be limited to
some support functions. If we hardcode this stuff all over the place it
will be more difficult to take non-ascii alphanumeric characters into
acoount if that is needed some day.
> > Then I would also like to know why this problem was introduced.
Probably
> > not by removing the code you just added (or was it done by accident?).
>
> Probably by adding the overloaded << operator and not taking the
appropriate
> actions.
Ah, you just copied existing stuff. If I had known that I would not have
asked.
> No, I am not sure of anything, but I can't see what problem could be
> introduced. The \sinx problem was introduced by overlooking, IMO.
Yes, I think so too. I asked because I wanted to avoid a bug fixing ping
pong (I took part in one already).
Georg
