Jean-Marc Lasgouttes wrote:
"Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes:
Abdelrazak> Your solution is good for single window LyX because then
Abdelrazak> the tab bar would just offer the same document list as the
Abdelrazak> View menu.
Abdelrazak> With multiple windows (views really), we have a problem.
Abdelrazak> On one hand, I want to have access to the full View menu
Abdelrazak> on any windows (there is a bug there by the way(*)). On
Abdelrazak> the second hand I don't want the tab bar to have the exact
Abdelrazak> same contents in every window.
So the tabs should have the list of buffers in current view, while the
Menu should have all buffers, irrespectively of the view, right? This
hardly requires fancy widgets.
I am not talking about fancy widget but about reusing widget that is
already doing the job for us in Qt.
I think BTW that we should think thoroughly about what we want to
obtain. The UI is not straightforward.
Abdelrazak> Using a tab widget would enable me to choose very easily
Abdelrazak> which tabs I want in this window and which other I want in
Abdelrazak> this other window.
You mean easier than adding a 'if' in a for loop?
Yes. An if loop in the menu stuff doesn't sound right. This looks much
better to my eyes:
GuiView::addWorkArea(GuiWorkArea *)
Don't forget that, right now the LyXView just pass the setBuffer() call
to the BufferView inside the WorkArea. Up until now LyXView doesn't know
about documents. The BufferView knows and I would like to keep it that way.
Abdelrazak> It will also permit to "detach" a tab onto a new window.
Doing drag and drop of tabs between windows would be indeed very
funny. I do not think it deserves a lot of work, however.
It is not about drag and drop. A simple right-click "Detach" on the tab
would do fine for me.
Abdelrazak> All this would be very easy to implement with very minimal
Abdelrazak> code if we goes the QTabWidget way. I would just be a
Abdelrazak> matter of adding/removing workareas (with their attached
Abdelrazak> BufferView and thus Buffer) to the LyXViews.
I doubt the code would be simpler. The fun factor would be higher for
you, though, and I can understand that.
The code would be very simpler in the future, I am pretty sure of that.
Abdel.
