Joost Verburg wrote: > The attached patch solves the problem: > > * When running on Windows, configure.py will not detect viewers and let > Windows handle it (write 'auto'). When an external application handles > auto-detection, a viewer entry can be added. > > * Auto-detection inside LyX will use the OS viewer when configure.py has > returned 'auto'. Again this is always the case on Windows except some > special application handles auto-detection.
That breaks the auto feature on OS X and linux. OK, linux does only have it in my experimental kde branch yet, but something like this will come sooner or later. > * It makes configuration faster because configure.py does not attempt to > detect UNIX applications on Windows. How much faster? > Comments? If this is acceptable, I will write a "pdfview" application to > improve PDF viewing on Windows. That is the wrong approach IMO. We discussed this extensively some time ago and came to the current solution where the OS takes precedence. If you insist that your pdf wrapper script should not be registered with the OS, but should be a special LyX script then I think you should put it in lib/scripts. configure.py would pick it up on windows, and fixCommand() would call os::canAutoOpenFile() only for viewers that do not contain the $$s placeholder. That would be cleaner IMO, because in general the OS takes still precedence, and only if we know that something comes from LyX we use that. Your patch introduces different semantics of configure.py on windows and other systems, and it breaks the auto feautre on all OSes but windows. Both is not good. Georg
