Angus Leeming wrote:
Abdelrazak Younes <[EMAIL PROTECTED]> writes:
Hello,
Following Andre suggestion and following discussion here is a patch that
cleans up everything related to singleton. The other important change is
that lyx::dispatch() and lyx::getStatus become _the_ official way to use
LyXFunc equivalent methods.
* lyxfunc.h:
- theLyXFunc(): new function in the global namespace.
* bufferlist.h:
- theBufferList(): new function in the global namespace.
In general, this is nice. However, I don't think that you should add
*anything* new to the global namespace. I think that these accessors should be
named
lyx::LyXFunc lyx::theLyXFunc();
lyx::BufferList lyx::theBufferList();
etc.
Of course, I realize that what you've done is a huge amount of work and that
I'm now far, far away, so feel free to pretend to not hear my complaints ;-)
I hear you Angus, even from far away. Doing this change is pretty simple
(global search and replace) and I don't have strong opinion either way.
Any other opinion?
Abdel.
