Georg Baum wrote:
Am Sonntag, 8. Oktober 2006 11:25 schrieb Abdelrazak Younes:

-       string label;
+       docstring label;
        // FIXME UNICODE
-       label += lyx::to_utf8(_("Box"));
-       label += " (";
+       label += _("Box");
+       label += lyx::from_utf8(" (");

No. Never use from_utf8 for pure ASCII (there are more cases like this below). As we have learned some time ago from André we can perfectly put

lyx::docstring operator+=(lyx::docstring & l, char const * r)

and

lyx::docstring operator+=(lyx::docstring & l, char r)

in docstring.C. I just committed those.

Very good. I've tried that actually and was deceived that it was still not in.


For other cases we have from_ascii.

That's fine with me but I remember there was a lot of discussion between you and Lars about that. That's the reason I did not use that. I'll do the changes.

Abdel.

Reply via email to