Am Samstag, 30. September 2006 01:10 schrieb Abdelrazak Younes:
> Hello,
> 
> This is done by creating two new pure virtual method in LyXView:
> 
> init(): initialize menubars and toolbars
> setGeometry(): guess what it does? :-)
> 
> I am not sure gtk and qt3 compiles but it should be close to.

Yep. The only problem was this nasty signals macro in qt3.

> +void QtView::setGeometry(unsigned int width,
> +                                                unsigned int height,
> +                                                int posx, int posy,
> +                                                bool maximize)

I noticed in some of your last commits these large indentations. Please 
either indent function arguments with exactly two tabs:

void QtView::setGeometry(unsigned int width, unsigned int height,
                int posx, int posy, bool maximize)

Or with as many spaces as are needed to align with the first argument:

void QtView::setGeometry(unsigned int width, unsigned int height,
                         int posx, int posy, bool maximize)


Both styles are used in LyX, I don't know which one is preferred, but the 
indentation above looks strange.


Georg

Reply via email to