Am Samstag, 30. September 2006 12:07 schrieb Abdelrazak Younes:

> I noticed that your fix does re-include LyXView.h and WorkArea.h. These 
> should not be necessary.

They are pulled in from something else, and because that happens after 
including qt headers they cause the signals name clash.

> Also Application_pimpl.h should not be  
> necessary anymore, I forgot to remove it.

Indeed, I just did it.

> >> +void QtView::setGeometry(unsigned int width,
> >> +                                                unsigned int height,
> >> +                                                int posx, int posy,
> >> +                                                bool maximize)
> > 
> > I noticed in some of your last commits these large indentations.
> 
> Isn't this just because of the extra '+' character in the patch?

No. The real file looks alike.

> Looks fine here in my editor. Weird.

Then it probably does some translation.


Georg

Reply via email to