Abdelrazak Younes <[EMAIL PROTECTED]> writes:
| While re-compiling LyX, I noticed the following warning:
|
| ..\..\..\src\lyxfunc.C(218) : warning C4244: 'initializing' :
| conversion from 'lyx::char_type' to 'char', possible loss of data
|
| in
|
| void LyXFunc::handleKeyFunc(kb_action action)
| {
| char c = encoded_last_key;
|
|
| The problem is that this "encoded_last_key member" is never written
| anywhere because it is overridden by a local variable in:
|
| void LyXFunc::processKeySym(LyXKeySymPtr keysym, key_modifier::state state)
| {
| [...]
| //encoded_last_key = keysym->getISOEncoded(encoding ?
| encoding->name() : "");
| size_t encoded_last_key = keysym->getUCSEncoded();
|
|
| I guess the additional "size_t" is a typo (Lars?). There seems to be
| no side effect in removing it. Shall I commit the fix?
No I don't think so. I think that the member shoulr be removed and its
usage for this "getTransManager" should be cleaned up. We really do
not want to handle dead-keys ourselves, that should be the
desktop/frontend that handles that.
I want to get rid of the whole TransManager stuff.
Also the whole LFUN_ACCENT stuff needs to be reworked in the light of
unicode, as well as the InsetLatexAccent. (Which should be just plain
codepoints, perhaps with the use of combining marks.)
--
Lgb
