While re-compiling LyX, I noticed the following warning:

..\..\..\src\lyxfunc.C(218) : warning C4244: 'initializing' : conversion from 'lyx::char_type' to 'char', possible loss of data

in

 void LyXFunc::handleKeyFunc(kb_action action)
 {
        char c = encoded_last_key;


The problem is that this "encoded_last_key member" is never written anywhere because it is overridden by a local variable in:

void LyXFunc::processKeySym(LyXKeySymPtr keysym, key_modifier::state state)
{
[...]
//encoded_last_key = keysym->getISOEncoded(encoding ? encoding->name() : "");
        size_t encoded_last_key = keysym->getUCSEncoded();


I guess the additional "size_t" is a typo (Lars?). There seems to be no side effect in removing it. Shall I commit the fix?

Abdel.


Reply via email to