This function while useful is also a pain in the neck:
        string askForText(string, string);

Yesterday, I was bitten by the "cancel-vc-checkin" bug and went looking
for a cause.  The problem is that askForText() lets you cancel an entry
but there is no way for the calling function to know that the cancel
button was pressed.

Asger has already suggested a reworking of this collection of useful
popups (from lyx_gui_misc.[hC]) but for now perhaps we could change the
signature of the function to one of the following:

        pair<bool, string> askForText(string const &, string const &);
        bool askForText(string &, string const &, string const &);
        string askForText(bool, string const &, string const &);

Any of these gets us a bool but also mean we need at least one named
variable to use at least one of the bool or string.  I prefer the pair<>
myself but I'm interested in hearing other ideas.  Especially ideas for
cleaning or reorganizing these helper popups with gui-independence in
mind.  Asger?

Allan. (ARRae)

P.S. Asger, if you can read this you might like to fix the forwarding of
email from diku.dk to sofusmedical since I've been getting mail-delivery 
errors for nearly a week now on that account (via cvslog).

Reply via email to