Quoting Nikola Kotur (kotn...@gmail.com):
>       switch (c) {
> -     case 'e': elevated_privileges = 1; break;
> +     case 'e':
> +             ret = lxc_fill_elevated_privileges(arg, &elevated_privileges);
> +             if (ret)
> +                     return -1;
> +             break;
>       case 'R': remount_sys_proc = 1; break;
>       case 'a':
>               new_personality = lxc_config_parse_arch(arg);
> @@ -102,7 +106,7 @@ static int my_parser(struct lxc_arguments* args, int c, 
> char* arg)
>               if (ret)
>                       return -1;
>               /* -s implies -e */
> -             elevated_privileges = 1;
> +             lxc_fill_elevated_privileges(NULL, &elevated_privileges);

Note I've applied it as is, and this failure shouldn't ever happen
anyway, but you're not checking return value of
lxc_fill_elevated_privileges() here.

-serge

------------------------------------------------------------------------------
Shape the Mobile Experience: Free Subscription
Software experts and developers: Be at the forefront of tech innovation.
Intel(R) Software Adrenaline delivers strategic insight and game-changing 
conversations that shape the rapidly evolving mobile landscape. Sign up now. 
http://pubads.g.doubleclick.net/gampad/clk?id=63431311&iu=/4140/ostg.clktrk
_______________________________________________
Lxc-devel mailing list
Lxc-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/lxc-devel

Reply via email to