Quoting Christian Seiler (christ...@iwakd.de): > Sorry, I forgot to post to the list... > > -------- Original-Nachricht -------- > Betreff: Re: [lxc-devel] lxc-attach: NSS handling > Datum: Tue, 05 Mar 2013 00:01:55 +0100 > Von: Christian Seiler <christ...@iwakd.de> > An: Serge Hallyn <serge.hal...@ubuntu.com> > > Hi Serge, > > > So if you resend the patchset, I'd suggest this patch first, the > > /bin/sh as default one second, setuids ones next... > > I've implemented the use of 'getent', which now makes my life a LOT > easier (I have quite a few containers lying around with incompatible nss > versions) and then manually rebased the previous patches. > > > (Btw, do you have a github tree? Reviewing/acking patches is easier > > on the list, but for actually pushing patches to staging, going from > > github tree is much nicer) > > I've pushed my patches to: > https://github.com/chris-se/lxc/tree/attach-fixes-1 > > I've excluded the -u/-g patch for now (I realized that I should probably > include a man page update anyway), but the rest is in there. > > Do you want me to send a pull request?
Hm, I think ideally a resend of the patches, i.e. git format-patch -o patches.1 -n staging.. git send-email --compose <smtp-options> --thread --no-chain-reply-to patches.1 mentioning the git branch in the cover letter (which --compose pulls up) That way everyone can easily review inline (convenient) and either Stephane or I can trivially merge. (A merge request as such is not actually helpful to me - not sure if they are to Stephane as he uses the web tools sometimes I think) -serge ------------------------------------------------------------------------------ Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_feb _______________________________________________ Lxc-devel mailing list Lxc-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/lxc-devel