Hi Acee, Thank you for your quick response.
Em seg., 14 de abr. de 2025 às 12:06, Acee Lindem <acee.i...@gmail.com> escreveu: > > Hi Renato, > > > On Apr 13, 2025, at 11:50 AM, Renato Westphal <renatowestp...@gmail.com> > > wrote: > > > > Hi all, > > > > I'm implementing this draft and would like to share some feedback. > > > > There's an augmentation to the "router-capabilities" container that is > > wrong. Instead, it is the "router-capability" list within that > > container that should be augmented. > > Mahesh noted this as well and it is fixed in GitHub. That might have been a different issue. I just checked the latest -27 version and the augmentation to "router-capabilities" is still incorrect. As I progress with my SR implementation, I came across another issue related to augmentations. The module is currently augmenting the "extended-is-neighbor" and "mt-is-neighbor" containers, instead of augmenting the "instance" list within those containers. I believe it would be better to have the Adj-SID sub-TLVs directly associated with their respective IS reachability entries, rather than grouping all Adj-SID sub-TLVs for each "neighbor-id" together (in the case of parallel links, there might be multiple IS reachability entries for the same neighbor). I also suggest renaming the "sid-list" list to "adj-sid-sub-tlv" for consistency with the existing "prefix-sid-sub-tlv" list and to align with the OSPF SR module. It might also be a good idea to group all Adj-SID sub-TLVs inside an "adj-sid-sub-tlvs" container for consistency as well. Other than these minor issues, I think the module looks excellent. FWIW, I'm sharing [1] an example data file populated from a virtual IS-IS SR topology using the Holo routing stack. It's a partial implementation of this module, including fixes for the aforementioned issues. [1] https://gist.githubusercontent.com/rwestphal/aa85a402e7ed12f6da131b1a0e172c93/raw/dfe4cdbbac4abd21828e5dc9a9a60e5a5d51f9c1/ietf-isis-sr-mpls.json Best Regards, -- Renato Westphal _______________________________________________ Lsr mailing list -- lsr@ietf.org To unsubscribe send an email to lsr-le...@ietf.org
