Hi Renato,
> On Apr 13, 2025, at 11:50 AM, Renato Westphal <renatowestp...@gmail.com>
> wrote:
>
> Hi all,
>
> I'm implementing this draft and would like to share some feedback.
>
> There's an augmentation to the "router-capabilities" container that is
> wrong. Instead, it is the "router-capability" list within that
> container that should be augmented.
Mahesh noted this as well and it is fixed in GitHub.
>
> Another issue, in my view, is that the "prefix-sid-sub-tlv" list is
> keyed by the "sid" leaf, which is a "uint32" whose interpretation
> depends on the Prefix-SID flags ("prefix-sid-flags"). This means it
> would be impossible to have two SIDs with the same value in the list,
> where one represents an index and the other an absolute label value. I
> believe "prefix-sid-sub-tlv" shouldn't have any keys, as is the case
> in the OSPF-SR module.
I agree and will remove the keys from these read-only lists.
Thanks,
Acee
>
> Best Regards,
> Renato.
>
> Em ter., 1 de abr. de 2025 às 21:58, <internet-dra...@ietf.org> escreveu:
>>
>> Internet-Draft draft-ietf-isis-sr-yang-26.txt is now available. It is a work
>> item of the Link State Routing (LSR) WG of the IETF.
>>
>> Title: A YANG Data Model for IS-IS Segment Routing for the MPLS Data
>> Plane
>> Authors: Stephane Litkowski
>> Yingzhen Qu
>> Pushpasis Sarkar
>> Ing-Wher Chen
>> Jeff Tantsura
>> Name: draft-ietf-isis-sr-yang-26.txt
>> Pages: 33
>> Dates: 2025-04-01
>>
>> Abstract:
>>
>> This document defines a YANG data module that can be used to
>> configure and manage IS-IS Segment Routing for MPLS data plane.
>>
>> The IETF datatracker status page for this Internet-Draft is:
>> https://datatracker.ietf.org/doc/draft-ietf-isis-sr-yang/
>>
>> There is also an HTML version available at:
>> https://www.ietf.org/archive/id/draft-ietf-isis-sr-yang-26.html
>>
>> A diff from the previous version is available at:
>> https://author-tools.ietf.org/iddiff?url2=draft-ietf-isis-sr-yang-26
>>
>> Internet-Drafts are also available by rsync at:
>> rsync.ietf.org::internet-drafts
>>
>>
>> _______________________________________________
>> Lsr mailing list -- lsr@ietf.org
>> To unsubscribe send an email to lsr-le...@ietf.org
>
>
>
> --
> Renato Westphal
>
> _______________________________________________
> Lsr mailing list -- lsr@ietf.org
> To unsubscribe send an email to lsr-le...@ietf.org
_______________________________________________
Lsr mailing list -- lsr@ietf.org
To unsubscribe send an email to lsr-le...@ietf.org
