On Apr 9, 2007, at 10:22 AM, Reid Spencer wrote: > On Mon, 2007-04-09 at 10:14 -0700, Chris Lattner wrote: >> The function and callinst dtors need to delete their attributes. > > No one is setting these yet so there's no leaks.
I understand. > The next patch will > unique the attributes in which case they should *not* be deleted. Use > of ParamAttrsList in Function and CallInst won't begin until the > uniquing is implemented. Uniquing is tricky in the face of mutation. I'd suggest doing an intermediate increment where you *just* move the attributes to call/ invoke/function without uniquing, then unique them as another step. > Speaking of which, do these need to be refcounted so they go away when > the last use disappears? Yep, that sounds good. -Chris _______________________________________________ llvm-commits mailing list llvm-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
