On Mon, 2007-04-09 at 10:14 -0700, Chris Lattner wrote: > The function and callinst dtors need to delete their attributes.
No one is setting these yet so there's no leaks. The next patch will unique the attributes in which case they should *not* be deleted. Use of ParamAttrsList in Function and CallInst won't begin until the uniquing is implemented. Speaking of which, do these need to be refcounted so they go away when the last use disappears? > > -Chris > > On Apr 9, 2007, at 8:01 AM, Reid Spencer wrote: > > > > > > > Changes in directory llvm/lib/VMCore: > > > > Function.cpp updated: 1.116 -> 1.117 > > Instructions.cpp updated: 1.81 -> 1.82 > > Type.cpp updated: 1.179 -> 1.180 > > --- > > Log message: > > > > For PR1146: http://llvm.org/PR1146 : > > * Add ParamAttrList pointers to Function and CallInst. > > * Move the implementation of ParamAttrList from Type.cpp to > > Function.cpp > > _______________________________________________ > llvm-commits mailing list > llvm-commits@cs.uiuc.edu > http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
signature.asc
Description: This is a digitally signed message part
_______________________________________________ llvm-commits mailing list llvm-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
