Nick,

Changes are in. A couple of things you can focus on future changes. If you find yourself duplicating sections of code, factor out the common bits and move them up into the common PPC class - it's not forbidden to do so. :) Second, now that you have a proper subclass, you should be able to remove cases of !IsDarwin.

Cheers,

-- Jim




On 20-Dec-06, at 09:20 PM, Nick Lewycky wrote:

The original patch had a merge error and wouldn't compile. This one has
been fixed. As well, a large #if 0 has been replaced with a simple
"TODO" comment.

Nick
<ppclinux.3.1.patch>
_______________________________________________
llvm-commits mailing list
llvm-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits

Attachment: smime.p7s
Description: S/MIME cryptographic signature

_______________________________________________
llvm-commits mailing list
llvm-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits

Reply via email to