| Issue |
204488
|
| Summary |
Improve handling of AllowLDSDMA in SIInstrInfo.isVALU
|
| Labels |
backend:AMDGPU
|
| Assignees |
|
| Reporter |
jrbyrnes
|
https://github.com/llvm/llvm-project/pull/203548 added a flag `AllowLDSDMA` to give users of isVALU the ability to not pick up LDSDMA instructions as well. While this is a convenience, the main intention was to make users aware that isVALU picked these instructions up.
In https://github.com/llvm/llvm-project/pull/203548#issuecomment-4710142559 we discussed the direction we should take this. In short, the next steps are to:
- always set `AllowLDSDMA` to false -- this implies taking a look at the users of this method and possibly changing the logic around the users to reflect isVALU no longer picks these up. For example, we may have some clients which rely on this behavior. Commits that set `AllowLDSDMA` to false should either be: 1. NFC or 2. bug fixes (where we erroneously picked up LDSDMA without meaning to).
- explore the possibility of no longer marking LDSDMA as VALU and removing this flag entirely from isVALU
![]()
_______________________________________________
llvm-bugs mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-bugs
