agozillon wrote:

> > > You could do the renaming of the pass as an NFC PR so it would make the 
> > > non NFC changes more obvious to spot at. Not necessary to do it for this 
> > > time but next time it would be nice.
> > 
> > 
> > I'm very sorry about that! I didn't realise it would be a problem, but I 
> > will keep it in mind for the future for any renaming + change sets I aim to 
> > upstream. Thank you for bringing it up.
> 
> Not an issue at all. It's just simpler to look at small PRs :-)

Yes, I am sorry about that, I'd like to make it as easy as possible to review 
for you all as I know it's not an easy task and I greatly appreciate the effort 
you all put in, so I will most definitely keep it mind in the future! 

https://github.com/llvm/llvm-project/pull/82853
_______________________________________________
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
  • [... via llvm-branch-commits
    • ... via llvm-branch-commits
    • ... Valentin Clement バレンタイン クレメン via llvm-branch-commits
    • ... via llvm-branch-commits
    • ... Valentin Clement バレンタイン クレメン via llvm-branch-commits
    • ... via llvm-branch-commits
    • ... via llvm-branch-commits
    • ... Valentin Clement バレンタイン クレメン via llvm-branch-commits
    • ... via llvm-branch-commits
    • ... Krzysztof Parzyszek via llvm-branch-commits
    • ... via llvm-branch-commits
    • ... via llvm-branch-commits
    • ... via llvm-branch-commits
    • ... via llvm-branch-commits
    • ... via llvm-branch-commits
    • ... via llvm-branch-commits
    • ... via llvm-branch-commits

Reply via email to