YungRaj wrote:

> The change itself looks good modulo formatting. Can you please update one of 
> the existing tests to cover this use case?

This doesn't get symbolication fully working. We still need to prevent the 
object file from being read when inspecting the symbolicated addresses through 
disassembly of instructions or by reading the contents of that memory.

I can fix all the unit tests once we get the ball fully rolled there. What are 
your recommendations for getting that working? Is that an issue with 
`Target::ReadMemory()` and the such?

https://github.com/llvm/llvm-project/pull/101062
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to