https://github.com/labath approved this pull request.
The change makes sense to me, but this part here got me worried: > then asked for a better object file, which returned the same program file > again Does this mean that we had two ObjectFileELF instances referring to the same file on disk floating around? That does not seem like a good idea, as the most common case is having the same file containing both the debug info and code and everything. Ideally, we would quickly determine that we have not been able to find a better match and avoid opening (parsing, mmaping, etc.) the same file twice. https://github.com/llvm/llvm-project/pull/91585 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits