jasonmolenda wrote: > > is about how TestAddressMasks.py assumes all Fix*Address implementations > > will handle a low and high memory address mask. The test currently assumes > > they do > > I'm not sure it makes much difference unless handling low/high produces a > large amount of boilerplate in every plugin. > > It is a bit of a foot gun to be able to tell the plugin for, for example, Arm > 32, that it has high/low mem masks. Since they won't make any sense, but it's > pretty well hidden.
I agree, the more I think about this the less I'm delighted by making every plugin support high/low address masks when it may not make any sense there. I like keeping the support in the SysV AArch64 ABI even though it's not used on Linux in case this ABI were used for generic AArch64 firmware debug scenario where someone might try to use that ABI plugin. In the API test, I can have a dedicated test for the highmem checks an only run it on aarch64/arm64 targets. I can add a test for the non-aarch64/arm64 targets which tests that setting the highmem mask has no effect (and remove the highmem support from the base ABI method impl). https://github.com/llvm/llvm-project/pull/83663 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
