DavidSpickett wrote:

>  is about how TestAddressMasks.py assumes all Fix*Address implementations 
> will handle a low and high memory address mask. The test currently assumes 
> they do

I'm not sure it makes much difference unless handling low/high produces a large 
amount of boilerplate in every plugin.

It is a bit of a foot gun to be able to tell the plugin for, for example, Arm 
32, that it has high/low mem masks. Since they won't make any sense, but it's 
pretty well hidden.

If somehow Arm/ppc/mips/intel/s390x grew a need to handle high/low mem and 
needed zero changes other than the mask, folks would be able to just set it 
without changing lldb (though I expect that wouldn't be the only change needed 
anyway).

https://github.com/llvm/llvm-project/pull/83663
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to