================
@@ -2225,7 +2225,8 @@ void ObjectFileMachO::ParseSymtab(Symtab &symtab) {
   const char *file_name = file.GetFilename().AsCString("<Unknown>");
   LLDB_SCOPED_TIMERF("ObjectFileMachO::ParseSymtab () module = %s", file_name);
   LLDB_LOG(log, "Parsing symbol table for {0}", file_name);
-  Progress progress(llvm::formatv("Parsing symbol table for {0}", file_name));
+  Progress progress(llvm::formatv("Parsing symbol table for {0}", file_name),
+                    Progress::ProgressReportType::eAggregateProgressReport);
----------------
medismailben wrote:

@clayborg I understand your point but how would a category string be different 
from filtering out the progress events based on the progress title string (or 
parts of it) ?

I see how certain progress reports could be relevant to linux where we wouldn't 
want to surface it on macOS. The reason we came up with this approach is 
precisely because we prefer having LLDB tell its clients what progress should 
be displayed, rather than having the filtering logic be done in the client.

May we could keep a list of blacklisted progress title / categories for every 
platform and either submit progress reports if they're not in that list or have 
an SBAPI to fetch the list of blacklisted progresses from the client ? What do 
you think about this ?

(also cc @JDevlieghere since he will probably have some opinions about this).

https://github.com/llvm/llvm-project/pull/69516
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to