DavidSpickett marked 3 inline comments as done. DavidSpickett added inline comments.
================ Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp:422 + m_sve_state = SVEState::Unknown; + m_sve_state_data.Invalidate(); + m_ssve_state_data.Invalidate(); ---------------- omjavaid wrote: > shouldnt we also invalidate all other dynamic regsets here? This is not needed anymore as we're no longer going to trigger a mode switch here. When we write to FPSIMD, we'll use the bottom 128 bits of the streaming mode Z register. Instead of going back to NT_ARM_SVE, which would cause a mode switch. ================ Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.h:116 + + SVEStateData m_sve_state_data; + SVEStateData m_ssve_state_data; ---------------- omjavaid wrote: > When we are in streaming mode normal state data will be invalid? If yes then > can we convert this into a pointer which should be pointing to a valid state > data based on current state? I've reverted to the previous scheme. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154926/new/ https://reviews.llvm.org/D154926 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
