JDevlieghere accepted this revision. JDevlieghere added inline comments.
================ Comment at: lldb/include/lldb/API/SBError.h:26 + SBError(const char *message); + ---------------- mib wrote: > bulbazord wrote: > > JDevlieghere wrote: > > > Why not a StringRef? > > I'm not sure we have `StringRef` type map in swig? We would have to create > > one for swig to pick up on it correctly, no? > +1 Yeah nvm, I got Status and SBError confused. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148401/new/ https://reviews.llvm.org/D148401 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
