mib added a comment.

In D148401#4275398 <https://reviews.llvm.org/D148401#4275398>, @bulbazord wrote:

> I like this! Reading through the call stack, it looks like we shouldn't hit 
> any issues if `message` is `nullptr`. Could you add a small test to 
> `TestSBError.py` constructing an error with a message directly?

Yep, we create the underlying status object if the opaque ptr is null. Will add 
a test case :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148401/new/

https://reviews.llvm.org/D148401

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to