aprantl added a comment.

Here is an example of how the Swift Runtime plugin detects both itself and 
whether ObjC interop is enabled. Basically all I'm asking is to not 
accidentally break this mechanism.
https://github.com/apple/llvm-project/blob/7750ffa35111df6d38a5c73ab7e78ccebc9b43c3/lldb/source/Plugins/LanguageRuntime/Swift/SwiftLanguageRuntime.cpp#L124
If you want to make 100% sure, you could checkout the Swift compiler on Linux 
(or I suppose Windows) from github.com/apple/swift run 
`swift/utils/update-checkout --clone` apply your patch to llvm-project and run 
`swift/utils/build-script --lldb --test -- --skip-build-benchmarks 
--skip-test-cmark --skip-test-swift` and make sure the lldb tests still pass 
after applying you patch. But if you check for the symbol that would be 
sufficient for me.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146154/new/

https://reviews.llvm.org/D146154

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to