sgraenitz added a comment.
Maybe I should have noted immediately, that this is mostly following the change
for Rust from https://reviews.llvm.org/D115300
================
Comment at: llvm/include/llvm/DebugInfo/CodeView/CodeView.h:142
+/// These values correspond to the CV_CFL_LANG enumeration in the Microsoft
+/// Debug Interface Access SDK
enum SourceLanguage : uint8_t {
----------------
DavidSpickett wrote:
> Could put the same link from the commit message, here.
I though about it, but such links will inevitably break again one day and/or
lead to outdated information. The old link was very unfortunate. Web search for
`CV_CFL_LANG Microsoft Debug Interface Access SDK` seems more stable. What do
you think?
================
Comment at: llvm/test/DebugInfo/COFF/objc.ll:4-6
+; ASM: .short 4412 # Record kind: S_COMPILE3
+; ASM-NEXT: .long 17 # Flags and language
+; ASM-NEXT: .short 208 # CPUType
----------------
DavidSpickett wrote:
> Are these checked, should they be?
Thanks for taking a look! What we check here is the `17` in language flags. The
rest is just to make sure we get the right context. (Same for the others.) Is
that your question?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146221/new/
https://reviews.llvm.org/D146221
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
