DavidSpickett added inline comments.
================
Comment at: llvm/include/llvm/DebugInfo/CodeView/CodeView.h:142
+/// These values correspond to the CV_CFL_LANG enumeration in the Microsoft
+/// Debug Interface Access SDK
enum SourceLanguage : uint8_t {
----------------
Could put the same link from the commit message, here.
================
Comment at: llvm/test/DebugInfo/COFF/objc.ll:4-6
+; ASM: .short 4412 # Record kind: S_COMPILE3
+; ASM-NEXT: .long 17 # Flags and language
+; ASM-NEXT: .short 208 # CPUType
----------------
Are these checked, should they be?
================
Comment at: llvm/test/DebugInfo/COFF/objc.ll:11-17
+; OBJ-NEXT: Flags [ (0x0)
+; OBJ-NEXT: ]
+; OBJ-NEXT: Machine: X64 (0xD0)
+; OBJ-NEXT: FrontendVersion: {{[0-9\.]*}}
+; OBJ-NEXT: BackendVersion: {{[0-9\.]*}}
+; OBJ-NEXT: VersionName: clang version 17.0.0
(https://github.com/llvm/llvm-project a8e9beca6bee1f248ef4be7892802c4d091b7fcb)
+; OBJ-NEXT: }
----------------
Do we need to check for these lines? Just the first few should be fine.
================
Comment at: llvm/test/DebugInfo/COFF/objcpp.ll:4-6
+; ASM: .short 4412 # Record kind: S_COMPILE3
+; ASM-NEXT: .long 18 # Flags and language
+; ASM-NEXT: .short 208 # CPUType
----------------
Are these checked, should they be?
================
Comment at: llvm/test/DebugInfo/COFF/objcpp.ll:11-17
+; OBJ-NEXT: Flags [ (0x0)
+; OBJ-NEXT: ]
+; OBJ-NEXT: Machine: X64 (0xD0)
+; OBJ-NEXT: FrontendVersion: {{[0-9\.]*}}
+; OBJ-NEXT: BackendVersion: {{[0-9\.]*}}
+; OBJ-NEXT: VersionName: clang version 17.0.0
(https://github.com/llvm/llvm-project a8e9beca6bee1f248ef4be7892802c4d091b7fcb)
+; OBJ-NEXT: }
----------------
Same here.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146221/new/
https://reviews.llvm.org/D146221
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
