bulbazord requested changes to this revision.
bulbazord added inline comments.
================
Comment at: lldb/source/Plugins/Process/scripted/ScriptedProcess.cpp:421
Target &target = GetTarget();
+ bool force_lookup = m_scripted_metadata.GetClassName().contains("CrashLog");
----------------
JDevlieghere wrote:
> This seems inverted: rather than the generic scripted process implementation
> having to know about a concrete implementation, why not make this a
> capability that the crashlog can opt into?
Instead of relying on the class name being `CrashLog`, why not ask the scripted
metadata for its capabilities? Something like `bool force_lookup =
m_scripted_metadata.ShouldForceSymbolFileLookup();` or something to this effect?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D141702/new/
https://reviews.llvm.org/D141702
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
