labath added inline comments.
================ Comment at: lldb/include/lldb/Interpreter/OptionGroupPlatform.h:73 bool m_include_platform_option; + OptionGroupPythonClassWithDict m_class_options; }; ---------------- labath wrote: > These nested groups are fairly unusual? Couldn't CommandObjectPlatformSelect > just have two OptionGroup members? I see that this is referenced in `OptionGroupPlatform::CreatePlatformWithOptions`. Maybe that could be fixed by moving that functions somewhere else (making it a free function) and having it take the two groups as arguments? Creating a platforms seems like too high-level of a task for an option group anyway... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139249/new/ https://reviews.llvm.org/D139249 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
