clayborg added a comment. In D138618#3963767 <https://reviews.llvm.org/D138618#3963767>, @labath wrote:
> The explanation makes sense, and I *think* the patch is ok, but it's hard to > review it with all the noise. I still believe the DIERef change would be > better off as a separate patch, so that the change is not obscured by the > (hopefully mechanical) aspects of increasing the size of the offset field. I am saying we can't make the DIERef change separately because it breaks the buildbots. Without modifying the OSO stuff, we can't make this patch work. If we need to change the max DIE offsets size, we need all these fixes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138618/new/ https://reviews.llvm.org/D138618 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
