aprantl added inline comments.
================ Comment at: lldb/source/Host/macosx/objcxx/HostInfoMacOSX.mm:410 + LLDB_LOG(log, "xcrun returned exit code %d", status); + return ""; + } ---------------- JDevlieghere wrote: > Why not return an Error? For the caller of this lambda "there is no such SDK" is not an error that should be surfaced to the user. There's a loop that will try multiple alternate spellings until it finds a matching SDK. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138060/new/ https://reviews.llvm.org/D138060 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
