JDevlieghere requested changes to this revision.
JDevlieghere added inline comments.
This revision now requires changes to proceed.
================
Comment at: lldb/source/Host/macosx/objcxx/HostInfoMacOSX.mm:410
+ LLDB_LOG(log, "xcrun returned exit code %d", status);
+ return "";
+ }
----------------
Why not return an Error?
================
Comment at: lldb/source/Host/macosx/objcxx/HostInfoMacOSX.mm:414
+ LLDB_LOG(log, "xcrun returned no results");
+ return "";
+ }
----------------
Same question.
================
Comment at: lldb/source/Host/macosx/objcxx/HostInfoMacOSX.mm:495
LLDB_LOGF(log, "Couldn't find any matching SDK on host");
- return {};
+ return "";
}
----------------
Here too, why not return a `StringError` with the log message from the live
above?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D138060/new/
https://reviews.llvm.org/D138060
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
