labath added a comment.

That said, I am kinda surprised that this is the whole thing. I would have 
expected to see more here. In dwarf we specify the offsets of individual class 
members. Does PDB encode that information? If not, how does it handle the case 
when the definition of some class is missing? If that class is a member of some 
other class, the offsets of all subsequent members in the bigger class will be 
wrong? That will probably be true even if we are always able to obtain the size 
of the smaller class, because of things like vtable pointers.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134656/new/

https://reviews.llvm.org/D134656

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to