labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
LGTM modulo formatting.
================
Comment at: lldb/test/Shell/SymbolFile/NativePDB/packed_class_layout.cpp:24
+
+union __attribute__((packed, aligned(1))) U {
+ char c[2];
----------------
I suspect these attributes do not materially change the layout of the union
when it stands on its own. It might be more interesting to take this
under-aligned union, place it into a (regular) struct, and then check whether
we can print it correctly.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134656/new/
https://reviews.llvm.org/D134656
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
