aprantl added inline comments.
================ Comment at: lldb/packages/Python/lldbsuite/test/dotest.py:338-339 + if args.custom_libcpp: + os.environ['CUSTOM_LIBCPP'] = args.custom_libcpp + ---------------- JDevlieghere wrote: > Please don't rely on environment variables to pass arguments to the Make > invocation. This makes it really tedious to debug make invocations. Instead, > pass these explicitly as part of the make invocation from the builders > (`packages/Python/lldbsuite/test/builders/`). That is a very good point. Maybe we should just fix the -E option, which doesn't work anyway due to Makefiles setting CFLAGS_EXTRAS and use that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132257/new/ https://reviews.llvm.org/D132257 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
