JDevlieghere requested changes to this revision. JDevlieghere added inline comments. This revision now requires changes to proceed.
================ Comment at: lldb/packages/Python/lldbsuite/test/dotest.py:338-339 + if args.custom_libcpp: + os.environ['CUSTOM_LIBCPP'] = args.custom_libcpp + ---------------- Please don't rely on environment variables to pass arguments to the Make invocation. This makes it really tedious to debug make invocations. Instead, pass these explicitly as part of the make invocation from the builders (`packages/Python/lldbsuite/test/builders/`). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132257/new/ https://reviews.llvm.org/D132257 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits