kastiglione accepted this revision.
kastiglione added a comment.
This revision is now accepted and ready to land.

one typo to fix, but otherwise looks good



================
Comment at: lldb/examples/python/crashlog.py:690-691
+            self.crashlog.thread_exception_subtype = line[18:].strip()
+            if self.crashlog.exception['type']:
+                self.crashlog.exception['subtype']: 
self.crashlog.thread_exception_subtype
+        elif line.startswith('Exception Codes:'):
----------------
should this also be `if 'type' in self.crashlog.exception`?

typo, should be ` = ` instead of `: `


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131719/new/

https://reviews.llvm.org/D131719

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to