mib added inline comments.
================ Comment at: lldb/examples/python/crashlog.py:708-709 + if exception_extra_match: + if not self.crashlog.exception['type']: + return + self.crashlog.exception['message'] = exception_extra_match.group(1) ---------------- kastiglione wrote: > is this meaning to check that the key `'type'` exists, and that it is > false-y? Or, should it be checking whether the key `'type'` is in the > dictionary (`if key is not in dict`) > > also, this check could be hoisted out, and avoid performing the regex search > if the result isn't going to be used. As it is now, the regex search happens, > and the result is ignored if this condition is met. +1 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131719/new/ https://reviews.llvm.org/D131719 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
