labath added a comment. In D128268#3604077 <https://reviews.llvm.org/D128268#3604077>, @mstorsjo wrote:
> In D128268#3603931 <https://reviews.llvm.org/D128268#3603931>, @labath wrote: > >>> As a separate path forward, one could also consider to stop returning >>> two architecture specs from ObjectFilePECOFF::GetModuleSpecifications >>> for i386 files. >> >> I think that would be much more preferable. I think the current >> implementation GetModuleSpecifications is based on a misconception about >> what the multiple results of that function mean (a fat binary -- as you've >> discovered). >> >> We wouldn't want to return armv6-*-* (or armv7, v8, ...) for a file that >> claims it can be run on armv5. Elf files also return just a single result >> for i386 file. > > If we'd just set this to the baseline, i386, would that have any effect for > how lldb e.g. is able to disassemble/interpret instructions that don't exist > in the i386 baseline architecture? It should not have any effect (if it does, that's a separate fix). In the disassembler, we explicitly enable the latest instruction set, and I can't think of anything else that would be impacted by it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128268/new/ https://reviews.llvm.org/D128268 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
