labath added a comment.

> As a separate path forward, one could also consider to stop returning
> two architecture specs from ObjectFilePECOFF::GetModuleSpecifications
> for i386 files.

I think that would be much more preferable. I think the current implementation 
GetModuleSpecifications is based on a misconception about what the multiple 
results of that function mean (a fat binary -- as you've discovered).

We wouldn't want to return armv6-*-* (or armv7, v8, ...) for a file that claims 
it can be run on armv5. Elf files also return just a single result for i386 
file.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128268/new/

https://reviews.llvm.org/D128268

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to