aprantl added inline comments.
================
Comment at: lldb/include/lldb/Utility/Log.h:98
+class SystemLogHandler : public LogHandler {
+public:
----------------
Doxygen comment?
================
Comment at: lldb/source/Utility/Log.cpp:406
+ if (__builtin_available(macos 10.12, iOS 10, tvOS 10, watchOS 3, *)) {
+ os_log(g_os_log, "%{public}s", str.c_str());
+ } else {
----------------
Can you add a FIXME for future reference that this ought to be moved into a
macro into the header, so we can benefit from os_log's special compiler support
and the only reason why we don't do this is that it's unsafe to include
<os/log.h> in the LLVM headers?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128321/new/
https://reviews.llvm.org/D128321
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
