jj10306 accepted this revision.
jj10306 added inline comments.
This revision is now accepted and ready to land.
================
Comment at: lldb/source/Plugins/Process/Linux/IntelPTSingleBufferTrace.cpp:211
+Error IntelPTSingleBufferTrace::SetCollectionState(
+ TraceCollectionState new_state) {
----------------
nit: from the "Set" name, my first impression was this method was simply
setting `m_collection_state`, but in reality it's doing some nontrivial
operations, namely changing the state of the perf event via ioctl. Consider
changing the name from "Set" to avoid giving the impression of a trivial
operation
================
Comment at: lldb/source/Plugins/Process/Linux/IntelPTSingleBufferTrace.cpp:309
return attr.takeError();
+ attr->disabled = initial_state == TraceCollectionState::Paused;
----------------
nice
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D124962/new/
https://reviews.llvm.org/D124962
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
