jj10306 added inline comments.
================
Comment at: lldb/source/Plugins/Process/Linux/IntelPTSingleBufferTrace.cpp:234
+IntelPTSingleBufferTrace::GetTraceBuffer(size_t offset, size_t size,
+ bool flush) {
std::vector<uint8_t> data(size, 0);
----------------
What's the purpose of this new `flush` flag? When would you want to call this
method with it set to false? I can only think of cases when you want to flush
the buffer if you're trying to read its data
================
Comment at: lldb/source/Plugins/Process/Linux/Perf.h:216-222
+ llvm::Error DisableWithIoctl() const;
+
+ /// Use the ioctl API to enable the perf event.
+ ///
+ /// \return
+ /// An Error if the perf event couldn't be enabled.
+ llvm::Error EnableWithIoctl() const;
----------------
Nice, happy to see we are extending the mini perf API (:
In the future we also can update this to control whether or not the event is
enabled at perf_event_open time because that's the default but there may be
cases where you don't want the event to be enabled until you explicitly enable
it w ioctl
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D124962/new/
https://reviews.llvm.org/D124962
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
