I agree that if we are going to start putting in errors for not finding listed arguments to “frame var” we should do it consistently, and Greg’s list seems good - along with the error “No debug info” when “frame var” is run in a frame w/o debug info or recognizers.
The one thing that bothers me slightly about this is that if I run “frame var” from HandleCommand in a script, with this change I can’t rely on the command status to tell whether the command output had anything interesting in it. That seems awkward. NB: speaking just for myself, I’m actually a little in favor of that potential breakage, since “the problem just shows that you shouldn’t be using HandleCommand in scripts”. But my non-mean self did feel like it ought to raise the issue… Jim > On Jan 10, 2022, at 5:27 PM, Dave Lee via Phabricator > <revi...@reviews.llvm.org> wrote: > > kastiglione added a comment. > >> Let me know your thoughts as mine are just my initial thoughts after >> thinking about things a bit more. > > For most of what you said, I was thinking the same. The only place where I > wasn't as sure about (regex), I was on the fence. Your cases and arguments > all seem good to me. I think the consistency is also good. > > thanks > > > Repository: > rG LLVM Github Monorepo > > CHANGES SINCE LAST ACTION > https://reviews.llvm.org/D116788/new/ > > https://reviews.llvm.org/D116788 > _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
