kastiglione added a comment.

> Let me know your thoughts as mine are just my initial thoughts after thinking 
> about things a bit more.

For most of what you said, I was thinking the same. The only place where I 
wasn't as sure about (regex), I was on the fence. Your cases and arguments all 
seem good to me. I think the consistency is also good.

thanks


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116788/new/

https://reviews.llvm.org/D116788

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to